Open
Conversation
adarshm11
reviewed
Apr 13, 2026
Contributor
adarshm11
left a comment
adarshm11
left a comment
There was a problem hiding this comment.
looks good so far, you can proceed with dockerfile when ready
jindoridodi
commented
Apr 16, 2026
|
|
||
| COPY frontend/ . | ||
|
|
||
| CMD ["npm", "run", "dev", "--", "--host", "0.0.0.0", "--port", "7777"] |
Collaborator
Author
There was a problem hiding this comment.
should this also be 6767 since 6767 is exposed in the backend portion?
Contributor
There was a problem hiding this comment.
6767 is the backend port, so this will need to be a different port, we can go with 6766
adarshm11
reviewed
Apr 16, 2026
Contributor
adarshm11
left a comment
adarshm11
left a comment
There was a problem hiding this comment.
oof there are some naming/organizational conflicts here. the Dockerfiles for frontend and backend should be separated and placed next to the code they run, so let's do this:
- move the frontend content from
Dockerfileto a new filefrontend/Dockerfile - move the frontend content from
Dockerfile.devto a new filefrontend/Dockerfile.dev - for
Dockerfile.dev(which now only contains the dev setup for the backend), look up the "air" dev tool. this will allow us to run the Go backend in dev mode with hot reloading (i.e. when we make a change, the code automatically updates rather than requiring the container to be restarted manually). this will also require a.air.tomlfile in the project root. feel free to use ai to assist you on this - update references for the Dockerfile context in
docker-compose.dev.ymlanddocker-compose.yml!! and make sure to test running it all before you're done
|
|
||
| COPY frontend/ . | ||
|
|
||
| CMD ["npm", "run", "dev", "--", "--host", "0.0.0.0", "--port", "7777"] |
Contributor
There was a problem hiding this comment.
6767 is the backend port, so this will need to be a different port, we can go with 6766
…can do it on a diff computer)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2
Still have not set up the dockerfile yet tho